Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Clock package with k8s Clock package #4607

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Replace Clock package with k8s Clock package #4607

merged 1 commit into from
Feb 22, 2022

Conversation

lbernick
Copy link
Member

Changes

This commit replaces the Tekton clock package with a package from k8s with
equivalent functionality. There's no reason to duplicate functionality
provided in k8s api machinery libraries. In addition, the k8s version
is more fully-featured. No functional changes.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@lbernick
Replace Clock package with k8s Clock package
0d78947 
This commit replaces the Tekton clock package with a package from k8s with
equivalent functionality. There's no reason to duplicate functionality
provided in k8s api machinery libraries. In addition, the k8s version
is more fully-featured. No functional changes.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 22, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2022
@lbernick
Copy link
Member Author

/assign mattmoor

@lbernick
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

mattmoor
mattmoor reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2022
pritidesai
pritidesai approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @lbernick 👍

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@tekton-robot tekton-robot merged commit 302895b into tektoncd:main Feb 22, 2022
@lbernick lbernick mentioned this pull request Feb 25, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@pritidesai pritidesai pritidesai approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbernick @tekton-robot @pritidesai @mattmoor